Invalid change ordering?
Toby Johnson
toby at etjohnson.us
Sat Feb 10 10:21:29 EST 2007
Dirk wrote:
> Index: ActionHandler.pm
> ===================================================================
> --- ActionHandler.pm (revision 291)
> +++ ActionHandler.pm (working copy)
> @@ -575,7 +575,7 @@
>
> # recover this item within the current parent
> my $parentinfo = $physinfo->{parents}->{$row->{parentphys}};
> - if (undef $parentinfo->{deleted}) {
> + if (!defined $parentinfo->{deleted}) {
> $self->{errmsg} .= "Attempt to recover an active item '$physname':\n"
> . "$self->{physname_seen}\n";
>
I just noticed this line... regardless of the rest of the patch, you
definitely don't want to be doing an undef there; undef will un-define a
variable, not test for whether it's defined.
More information about the vss2svn-users
mailing list