share an orphaned item -> MOVE

Micke u23104331 at telia.com
Sun Feb 11 02:26:43 EST 2007


Dirk wrote:
>
>> a) SHARE of an orphaned item can become a MOVE instead.
>
> I did some work on this also. The actual patch for it was rather simple,
> but I had to change the MOVE handler also. Traditionally the move
> handler had a "twisted syntax". While all other handlers have the
> specification that the "parentphys" is the TARGET parent, while the
> "info" is the SOURCE parent. This was different for the MOVE handler.
> Here the parentphys was the move source and the info field the move
> target. This made it already difficult, since we had to switch the two
> fields sometimes in between. Now I came across the same problem again
> for the share handling and decided to fix this old behavior. While doing
> this I found a few places, where the MOVE handler could improve, and I
> still have a few unclear points. Esp. I don't know what the "# Don't
> know from where to move. Share it there instead" code in the
> ActionHandler::_move_handler should do.

I wrote that line. It just means that somewhere the trace has been lost
and what was once a MOVE now has several possible places from where it
is being moved. I chose to just leave all the move sources intact, i.e.
SHARE. Perhaps not the wisest thing to do. Some sort of copy might have
been slightly better.

Regards,
/Micke



More information about the vss2svn-users mailing list